Improving serialization #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
requested changes
Jul 31, 2024
src/abstractions/serialization/KiotaJsonSerializer.Serialization.cs
Outdated
Show resolved
Hide resolved
src/abstractions/serialization/KiotaJsonSerializer.Serialization.cs
Outdated
Show resolved
Hide resolved
src/abstractions/serialization/KiotaSerializer.Serialization.cs
Outdated
Show resolved
Hide resolved
baywet
reviewed
Aug 1, 2024
src/abstractions/serialization/KiotaJsonSerializer.Serialization.cs
Outdated
Show resolved
Hide resolved
baywet
reviewed
Aug 1, 2024
src/abstractions/serialization/KiotaSerializer.Serialization.cs
Outdated
Show resolved
Hide resolved
baywet
requested changes
Aug 1, 2024
|
It was a bit of pickle, but I think this is a pretty nice solution. Did I just notice that the backing store stuff if not referenced in any tests? |
baywet
reviewed
Aug 2, 2024
src/abstractions/serialization/SerializationWriterProxyFactory.cs
Outdated
Show resolved
Hide resolved
src/abstractions/serialization/SerializationWriterFactoryRegistry.cs
Outdated
Show resolved
Hide resolved
This way you have to include these packages as well, they will throw otherwise.
andrueastman
reviewed
Aug 5, 2024
|
I'm out of the office this week, and see that the formatting failed. I checked the box that I gave the contributors access to the branch. So if anybody wants to run |
baywet
previously approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Thank you for making the changes!
@andrueastman for final review and merge.
I believe we'll need a version bump/changelog entry as well.
baywet
previously approved these changes
Aug 19, 2024
andrueastman
approved these changes
Aug 20, 2024
baywet
approved these changes
Aug 20, 2024
This was referenced Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #310